Re: [Xen-devel] [PATCH] tools/kdd: don't use a pointer to an unaligned field.

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Fri, Mar 10, 2017 at 10:10:57AM +0000, Tim Deegan wrote:
> The 'val' field in the packet is byte-aligned (because it is part of a
> packed struct), but the pointer argument to kdd_rdmsr() has the normal
> alignment constraints for a uint64_t *.  Use a local variable to make sure
> the passed pointer has the correct alignment.
> 
> Reported-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Signed-off-by: Tim Deegan <tim@xxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Tested-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Right, I got messed up while manually calculating the offsets by hand... Thanks
for fixing this.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel