Re: [Xen-devel] [PATCH] common/mem_access: merged mem_access setting interfaces

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Thu, Mar 16, 2017 at 12:33 PM, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> wrote:

On 03/16/2017 08:10 PM, Tamas K Lengyel wrote:
>
>
>     diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
>     index 6eee0c8..ca53a0c 100644
>     --- a/xen/include/public/memory.h
>     +++ b/xen/include/public/memory.h
>     @@ -444,6 +444,8 @@ struct xen_mem_access_op {
>          /* xenmem_access_t */
>          uint8_t access;
>          domid_t domid;
>     +    uint16_t view_id;
>     +    uint16_t pad;
>
>
> I think this will mess with the next uint32_t struct member, so either
> this pad should be uint16_t pad[3], or another pad needs to be added
> after the following uint32_t nr.

Fair enough, I'll need to send V2 anyway as Roger's "x86: remove PVHv1
code" has also bumped XEN_DOMCTL_INTERFACE_VERSION and I now need to
take it out.

Sounds good. The patch looks good to me otherwise.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel