Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 17, 2017 at 11:06:41AM +0000, Andrew Cooper wrote:
> On 17/03/17 11:02, Wei Liu wrote:
> > A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest.
> > Now that PVHv1 is gone, undo that bodge and remove the fixme.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> This unfortunately needs to stay, although perhaps it wants rewording.
> 
> send_guest_trap() just out of context below is PV-specific, making this
> path unsuitable for any HVM guests.
> 

Just removing the comment should be fine then.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel