Re: [Xen-devel] [PATCH v2 2/4] x86: split PV dom0 builder to pv/dom0_builder.c

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 17, 2017 at 11:15:45AM +0000, Andrew Cooper wrote:
> On 16/03/17 17:54, Wei Liu wrote:
> > diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c
> > new file mode 100644
> > index 0000000000..bb82c33a4c
> > --- /dev/null
> > +++ b/xen/arch/x86/pv/dom0_build.c
> > @@ -0,0 +1,910 @@
> > +/******************************************************************************
> > + * pv/dom0_build.c
> > + *
> > + * Copyright (c) 2002-2005, K A Fraser
> > + */
> > +
> > +#include <xen/console.h>
> > +#include <xen/domain.h>
> > +#include <xen/domain_page.h>
> > +#include <xen/init.h>
> > +#include <xen/libelf.h>
> > +#include <xen/multiboot.h>
> > +#include <xen/paging.h>
> > +#include <xen/pfn.h>
> > +#include <xen/sched.h>
> > +#include <xen/softirq.h>
> > +
> > +#include <asm/bzimage.h>
> > +#include <asm/dom0_build.h>
> > +#include <asm/page.h>
> > +#include <asm/setup.h>
> > +
> > +/* Allow ring-3 access in long mode as guest cannot use ring 1 ... */
> > +#define BASE_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_USER)
> > +#define L1_PROT (BASE_PROT|_PAGE_GUEST_KERNEL)
> > +/* ... except for compatibility mode guests. */
> > +#define COMPAT_L1_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED)
> > +#define L2_PROT (BASE_PROT|_PAGE_DIRTY)
> > +#define L3_PROT (BASE_PROT|_PAGE_DIRTY)
> > +#define L4_PROT (BASE_PROT|_PAGE_DIRTY)
> > +
> > +static __init void dom0_update_physmap(struct domain *d, unsigned long pfn,
> > +                                   unsigned long mfn, unsigned long 
> > vphysmap_s)
> 
> Sorry to be awkward, but can you fix up all the style issues as part of
> moving this code?  There are a number of mis-indenting and missing newlines.
> 

No problem. Emacs is very good at this so it would be easy.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel