Re: [Xen-devel] [PATCH v3 4/5] x86: split PVH dom0 builder to hvm/dom0_build.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/03/17 14:14, Wei Liu wrote:
> Long term we want to be able to disentangle PV and HVM code. Move
> the PVH domain builder to a dedicated file.
>
> Lift function declarations to dom0_build.h and rename them when
> necessary.
>
> No functional change.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

One style nit.

> +    /* Copy the addresses of the rest of the allowed tables. */
> +    for( i = 0, j = 1; i < acpi_gbl_root_table_list.count; i++ )
> +    {
> +        const char *sig = acpi_gbl_root_table_list.tables[i].signature.ascii;
> +
> +        if ( pvh_acpi_table_allowed(sig) )
> +            xsdt->table_offset_entry[j++] =
> +                                acpi_gbl_root_table_list.tables[i].address;

Indentation.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel