Re: [Xen-devel] [PATCH v3 2/5] x86: modify setup_dom0_vcpu to use dom0_cpus internally

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Mar 20, 2017 at 09:19:43AM -0600, Jan Beulich wrote:
> >>> On 20.03.17 at 15:14, <wei.liu2@xxxxxxxxxx> wrote:
> > @@ -1155,8 +1157,10 @@ static int __init construct_dom0_pv(
> >      cpu = v->processor;
> >      for ( i = 1; i < d->max_vcpus; i++ )
> >      {
> > -        cpu = cpumask_cycle(cpu, &dom0_cpus);
> > -        setup_dom0_vcpu(d, i, cpu);
> > +        struct vcpu *p = setup_dom0_vcpu(d, i, cpu);
> 
> While not a big deal, as said, this would better be const. With
> that
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Sorry I missed that. I will make the changes while I commit these
patches.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel