Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.03.17 at 10:50, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -444,6 +444,8 @@ struct xen_mem_access_op {
>      /* xenmem_access_t */
>      uint8_t access;
>      domid_t domid;
> +    uint16_t view_id;
> +    uint16_t pad[3];

Irrespective of Andrew's valid general objection, the change above
wouldn't be valid either: How would you guarantee compatibility
with old callers? Other than in e.g. domctl/sysctl there's no
interface version here which can be bumped, so simply adding
fields to a structure and re-using an existing sub-op won't do.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel