Re: [Xen-devel] [PATCH v6] xen: Allow a default compiled-in command line using Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.03.17 at 17:32, <blackskygg@xxxxxxxxx> wrote:
> Added 2 new config entries in common/Kconfig:
>     CMDLINE and CMDLINE_OVERRIDE
> Modifed common/kernel.c:cmdline_parse().
> 
> The 2 new entries enable an embedded command line to be compiled
> in the hypervisor. CMDLINE depends on EXPERT = "y", and CMDLINE_OVERRIDE
> depends on CMDLINE != "".
> 
> If CMDLINE is set, it will be parsed prior to the bootloader command line.
> This order of parsing implies that if any non-cumulative options are set in
> both CMDLINE and the bootloader command line, only the ones in the latter will
> take effect. Further more, if CMDLINE_OVERRIDE is set to y, the whole
> bootloader command line will be ignored, which will be useful to work around
> broken bootloaders. A wrapper to the original 
> common/kernel.c:cmdline_parse()
> was introduced to complete this task.
> 
> This allows downstreams to set their defaults without modifying the source 
> code
> all over the place. Also probably useful for the embedded space.
> (See Also: https://xenproject.atlassian.net/browse/XEN-41)
> 
> Signed-off-by: Zhongze Liu <blackskygg@xxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

albeit I think the commit message should have what is now the 4th
paragraph first, with what are currently 1st and 2nd paragraphs
dropped altogether.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel