Re: [Xen-devel] [PATCH v2 09/12] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP

[Haozhong Zhang <haozhong.zhang@xxxxxxxxx>]

On 03/20/17 10:33 -0600, Jan Beulich wrote:
> >>> On 17.03.17 at 07:46, <haozhong.zhang@xxxxxxxxx> wrote:
> > --- a/xen/include/public/hvm/params.h
> > +++ b/xen/include/public/hvm/params.h
> > @@ -259,6 +259,11 @@
> >   */
> >  #define HVM_PARAM_VM86_TSS_SIZED 37
> >  
> > -#define HVM_NR_PARAMS 38
> > +/* Enable MCA capabilities. */
> > +#define HVM_PARAM_MCA_CAP 38
> > +#define HVMMCA_CAP_LMCE   (1UL << 27)
> 
> How come this is bit 27 rather than bit 0? Further, to match up with
> other, future definitions here, I think you mean 1ULL (or, to be
> precise, xen_mk_ullong()).
>

I intended to use the same bit in MSR_IA32_MCG_CAP to clarify its
semantic, but I realize it's unnecessary as I still need to introduce
HVMMCA_CAP_* for each bit.

Thanks,
Haozhong
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel