Re: [Xen-devel] [PATCH v7] xen: Allow a default compiled-in command line using Kconfig

[Zhongze Liu <blackskygg@xxxxxxxxx>]

2017-03-21 16:59 GMT+08:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:
> On Tue, 2017-03-21 at 16:43 +0800, Zhongze Liu wrote:
>> This allows downstreams to set their defaults without modifying the
>> source code
>> all over the place. Also probably useful for the embedded space.
>> (See Also: https://xenproject.atlassian.net/browse/XEN-41)
>>
>> Added 2 new config entries in common/Kconfig:
>>     CMDLINE and CMDLINE_OVERRIDE
>> Modified common/kernel.c:cmdline_parse().
>>
>> The 2 new entries enable an embedded command line to be compiled
>> in the hypervisor. CMDLINE depends on EXPERT = "y", and
>> CMDLINE_OVERRIDE
>> depends on CMDLINE != "".
>>
> Well, Jan also said:
>
> "albeit I think the commit message should have what is now the 4th
> paragraph first, with what are currently 1st and 2nd paragraphs
> dropped altogether."
>
> And those "1st and 2nd paragraphs" refers to, in this version, the text
> that goes from "Added 2 new..." to "...depends on CMDLINE != """,
> which, for what is worth, I agree does not add much and should be
> dropped.
>
> Although it's probably not a super big deal...
>

I thought these two paragraphs help people reading this message
understand more clearly what has been touched and what has been
done.
Although, as you put it, this is really not a super big dea, I'll try to make
my commit message more concise in my later patches.

Cheers.

Zhongze Liu

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel