Re: [Xen-devel] [PATCH v7] xen: Allow a default compiled-in command line using Kconfig

[Zhongze Liu <blackskygg@xxxxxxxxx>]

2017-03-21 17:37 GMT+08:00 Jan Beulich <JBeulich@xxxxxxxx>:
>>>> On 21.03.17 at 09:43, <blackskygg@xxxxxxxxx> wrote:
>> Added 2 new config entries in common/Kconfig:
>>     CMDLINE and CMDLINE_OVERRIDE
>> Modified common/kernel.c:cmdline_parse().
>>
>> The 2 new entries enable an embedded command line to be compiled
>> in the hypervisor. CMDLINE depends on EXPERT = "y", and CMDLINE_OVERRIDE
>> depends on CMDLINE != "".
>
> I'm slightly confused: Didn't you agree to my suggestion to drop
> these two paragraphs altogether? My intention is still to purge
> them while committing.
>
Sorry Jan, I didn't mean to confuse you. I think I should have said:
"partly agree" and
explain why. my fault, sorry. Having read through Dario's words, I now
understand
what your concerns are. And now I'm trying to develop a good taste of
commit messages.

I'm still learning things, so please do continue to point out my
problems if you find any. I
sincerely appreciate all the things I've learned here so far. Thanks.

Cheers.

Zhongze Liu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel