[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/hvm: switch some open-coded dpci access to use the provided macro

To: "Roger Pau Monne" <roger.pau@xxxxxxxxxx>
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Tue, 21 Mar 2017 10:33:26 -0600
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Mar 2017 16:33:42 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

>>> On 21.03.17 at 16:41, <roger.pau@xxxxxxxxxx> wrote:
> No functional change.

The reason it's done the original way is, I guess, that - other than
your title suggests - this is not a macro, and not even an inline
function. In cases where the two checks the function does aren't
needed, I think it is reasonable to avoid the call.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH] x86/hvm: switch some open-coded dpci access to use the provided macro
  - From: Roger Pau Monne

References:
- [Xen-devel] [PATCH] x86/hvm: switch some open-coded dpci access to use the provided macro
  - From: Roger Pau Monne

Prev by Date: Re: [Xen-devel] [PATCH v4] altp2m: Allow specifying external-only use-case
Next by Date: Re: [Xen-devel] [PATCH v8] xen: Allow a default compiled-in command line using Kconfig
Previous by thread: [Xen-devel] [PATCH] x86/hvm: switch some open-coded dpci access to use the provided macro
Next by thread: Re: [Xen-devel] [PATCH] x86/hvm: switch some open-coded dpci access to use the provided macro
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.