Re: [Xen-devel] [PATCH v4] altp2m: Allow specifying external-only use-case

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Mar 20, 2017 at 01:27:26PM -0600, Tamas K Lengyel wrote:
>  
>      if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM &&
>          (libxl_defbool_val(d_config->b_info.u.hvm.nested_hvm) &&
> -         libxl_defbool_val(d_config->b_info.u.hvm.altp2m))) {
> +        (libxl_defbool_val(d_config->b_info.u.hvm.altp2m) ||
> +        (d_config->b_info.altp2m != LIBXL_ALTP2M_MODE_DISABLED)))) {
> +        LOG(ERROR, "nestedhvm and altp2m cannot be used together");

Please use the LOGD macro here.

Otherwise, the toolstack code looks good.

There is a discussion pending on how many modes are needed, so I will
wait until that to settle down before I ack the toolstack bits.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel