Re: [Xen-devel] [PATCH v3 6/6] x86/viridian: implement the crash MSRs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.03.17 at 19:17, <paul.durrant@xxxxxxxxxx> wrote:
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -288,6 +288,12 @@
>  #define LIBXL_HAVE_SCHED_CREDIT2_PARAMS 1
>  
>  /*
> + * LIBXL_HAVE_CRASH_CTL indicates that the 'crash_ctl' value
> + * is present in the viridian enlightenment enumeration.
> + */
> +#define LIBXL_HAVE_CRASH_CTL 1

I was about to commit this together with 1, 3, and 4, when this
define caught my eye: Isn't the name a little too generic? I.e.
LIBXL_HAVE_VIRIDIAN_CRASH_CTL perhaps?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel