Re: [Xen-devel] [RFC PATCH 1/23] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities

["Lan, Tianyu" <tianyu.lan@xxxxxxxxx>]

On 3/22/2017 4:36 PM, Tian, Kevin wrote:
> > From: Julien Grall [mailto:julien.grall@xxxxxxx]
> > Sent: Wednesday, March 22, 2017 3:57 AM
> >
> > > diff --git a/xen/common/Makefile b/xen/common/Makefile index
> > > 0fed30b..b58de63 100644
> > > --- a/xen/common/Makefile
> > > +++ b/xen/common/Makefile
> > > @@ -60,6 +60,7 @@ obj-y += vm_event.o
> > >  obj-y += vmap.o
> > >  obj-y += vsprintf.o
> > >  obj-y += wait.o
> > > +obj-y += viommu.o
> > I see very little point to enable viommu by default on all architecture.
> > This is x86 specific and I am yet sure how we would be able to use it on ARM
> > as the current series rely on QEMU. Also this is waste space in struct domain.
> >
> > I would prefer if you introduce a Kconfig that would be select by x86 only.
> >
> > Regards,
> Also viommu.c is too generic. Each vendor should has his own
> implementation. better change to vvtd.c (and make more sense
> move to hvm)
Hi Kevin:
    vIommu is an abstract layer and we have added vvtd.c under hvm 
directory in the following patch. vvtd will register its callbacks to 
vIOMMU layer. This works just like IOMMU core and VTD driver.
> Thanks
> Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel