Re: [Xen-devel] [PATCH 10/10] tools/insn-fuzz: Always use x86_swint_emulate_all

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 27/03/17 10:56, Andrew Cooper wrote:
> The swint_emulate parameter indicates how much extra work the emulator needs
> to do to cover issues with certain hardware injection methods.
> 
> Using x86_swint_emulate_all opens up maximum coverage in the emulator.

Uh, no -- removing this means all of the x86_swint_emulate_none
codepaths don't get tested.

The idea here is to make sure that the emulator works for all possible
inputs.  Changing this means that there could (in theory) be a bug that
is only triggered when ctx->swint_emulate != x86_swint_emulate_all that
we wouldn't catch.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel