Re: [Xen-devel] [PATCH] libxl/xl: add support for Xen 9pfs

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Mon, 27 Mar 2017, Stefano Stabellini wrote:
> On Mon, 27 Mar 2017, Wei Liu wrote:
> > On Thu, Mar 23, 2017 at 04:36:19PM -0700, Stefano Stabellini wrote:
> > >  docs/man/xl.cfg.pod.5.in             | 31 +++++++++++++
> > >  tools/libxl/Makefile                 |  2 +-
> > >  tools/libxl/libxl.h                  | 10 +++++
> > >  tools/libxl/libxl_9pfs.c             | 87 
> > > ++++++++++++++++++++++++++++++++++++
> > >  tools/libxl/libxl_create.c           |  3 ++
> > >  tools/libxl/libxl_internal.h         |  6 +++
> > >  tools/libxl/libxl_types.idl          | 10 +++++
> > >  tools/libxl/libxl_types_internal.idl |  1 +
> > >  tools/xl/xl_parse.c                  | 55 ++++++++++++++++++++++-
> > >  9 files changed, 203 insertions(+), 2 deletions(-)
> > >  create mode 100644 tools/libxl/libxl_9pfs.c
> > > 
> > > diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
> > > index 505c111..699a644 100644
> > > --- a/docs/man/xl.cfg.pod.5.in
> > > +++ b/docs/man/xl.cfg.pod.5.in
> > > @@ -516,6 +516,37 @@ value is optional if this is a guest domain.
> > >  
> > >  =back
> > >  
> > > +=item B<xen_9pfs=[ "XEN_9PFS_SPEC_STRING", "XEN_9PFS_SPEC_STRING", ...]>
> > > +
> > 
> > Let me guess, the reason for xen_ prefix is 9pfs isn't really a valid
> > identifier in C.
> > 
> > Can we get rid of the xen_ prefix by naming everything p9* ? I think
> > that's how QEMU does it.
> 
> OK. I'll rename the VM config option to 9pfs, and all the internal
> functions and variables to 9p.

Actually the xl parser is also similarly constrained, so I'll have to
rename the VM config option to p9 too.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel