Re: [Xen-devel] [RFC PATCH v2 02/25] x86: NUMA: Fix datatypes and attributes

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 28, 2017 at 09:23:10PM +0530, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
> 
> Change u{8,32,64} to uint{8,32,64}_t and bool_t to bool.
> Fix attributes coding styles.
> Also change memnodeshift to unsigned int.

I think you also need to say you changed u64 to paddr_t where
appropriate.

> @@ -269,8 +269,8 @@ void __init numa_initmem_init(unsigned long start_pfn, 
> unsigned long end_pfn)
>             numa_off ? "NUMA turned off" : "No NUMA configuration found");
>  
>      printk(KERN_INFO "Faking a node at %016"PRIx64"-%016"PRIx64"\n",
> -           (u64)start_pfn << PAGE_SHIFT,
> -           (u64)end_pfn << PAGE_SHIFT);
> +           (uint64_t)start_pfn << PAGE_SHIFT,
> +           (uint64_t)end_pfn << PAGE_SHIFT);
>      /* setup dummy node covering all memory */
>      memnode_shift = BITS_PER_LONG - 1;
>      memnodemap = _memnodemap;
> @@ -279,8 +279,8 @@ void __init numa_initmem_init(unsigned long start_pfn, 
> unsigned long end_pfn)
>      for ( i = 0; i < nr_cpu_ids; i++ )
>          numa_set_node(i, 0);
>      cpumask_copy(&node_to_cpumask[0], cpumask_of(0));
> -    setup_node_bootmem(0, (u64)start_pfn << PAGE_SHIFT,
> -                    (u64)end_pfn << PAGE_SHIFT);
> +    setup_node_bootmem(0, (paddr_t)start_pfn << PAGE_SHIFT,
> +                    (paddr_t)end_pfn << PAGE_SHIFT);

Indentation.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel