Re: [Xen-devel] [PATCH v2 2/2] x86/io: move the list of guest to machine IO ports out of domain_iommu

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Wed, Mar 29, 2017 at 11:41:40AM +0100, Andrew Cooper wrote:
> On 28/03/17 14:12, Roger Pau Monne wrote:
> > There's no reason to store that list inside of the domain_iommu struct, the
> > forwarding of guest IO ports into machine IO ports is not tied to the 
> > presence
> > of an IOMMU.
> >
> > Move it inside of the hvm_domain struct instead.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Actually, on second thoughts, I rescind my R-by.
> 
> This breaks PV guests, which must not use state in the hvm half of the
> union.

I'm extremely confused now, AFAICT the g2m_ioport_list list is only used by the
g2m_portio_* handlers, and those handlers already make use of HVM only fields
(ie: hvm_vcpu_io).

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel