[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 04/19] xen/arm: Restore HCR_EL2 register



Hi Wei,

On 30/03/17 10:13, Wei Chen wrote:
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index de59e5f..8af223e 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2171,6 +2171,13 @@ int construct_dom0(struct domain *d)
         return rc;

     /*
+     * The HCR_EL2 will temporarily switch to dom0's HCR_EL2 value
+     * by p2m_restore_state. We have to save HCR_EL2 to idle vCPU's
+     * context for restoring it in later.
+     */
+    current->arch.hcr_el2 = READ_SYSREG(HCR_EL2);

I don't understand why we care here. idle vCPU will never restore HCR_EL2 nor return from the hypervisor.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.