Re: [Xen-devel] [PATCH v6 3/4] Introduce the Xen 9pfs transport header

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 30 Mar 2017, Jan Beulich wrote:
> >>> On 30.03.17 at 00:18, <sstabellini@xxxxxxxxxx> wrote:
> > --- a/xen/include/Makefile
> > +++ b/xen/include/Makefile
> > @@ -94,9 +94,12 @@ all: headers.chk headers99.chk headers++.chk
> >  
> >  PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard 
> > public/*.h public/*/*.h) $(public-y))
> >  
> > -PUBLIC_C99_HEADERS :=
> > +PUBLIC_C99_HEADERS := public/io/9pfs.h
> >  PUBLIC_ANSI_HEADERS := $(filter-out public/%ctl.h public/xsm/% 
> > public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS))
> >  
> > +public/io/9pfs.h-c99-prereq := -include string.h
> > +public/io/9pfs.h-cxx-prereq := -include cstring
> 
> For the moment (where we only have consistent prereqs) I wonder
> whether we couldn't simplify this to
> 
> public/io/9pfs.h-prereqs := string
> 
> with the C++ use site then becoming
> $(addprefix -include c,$($(i)-prereqs)) (C99 similar). In any event
> I'd like to see the -include go away from the macros here - they
> should at most list header names.

All right, but given that in the c99 case we need to add both a prefix
(-include) and a suffix (.h), I'll use foreach instead of addprefix.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel