Re: [Xen-devel] [PATCH v3 02/26] ARM: GICv3: allocate LPI pending and property table

[Julien Grall <julien.grall@xxxxxxx>]

On 03/04/17 14:53, Julien Grall wrote:
> > diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
> > index bd0883a..9261e06 100644
> > --- a/xen/include/xen/bitops.h
> > +++ b/xen/include/xen/bitops.h
> > @@ -5,11 +5,14 @@
> >  /*
> >   * Create a contiguous bitmask starting at bit position @l and ending at
> >   * position @h. For example
> > - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
> > + * GENMASK(30, 21) gives us the 32bit vector 0x7fe00000.
> This is a new addition in this series and should really be a separate
> patch with the appropriate maintainers CCed.
>
> >   */
> >  #define GENMASK(h, l) \
> >      (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
> >
> > +#define GENMASK_ULL(h, l) \
> > +    (((~0ULL) << (l)) & (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h))))
> This should also be a separate patch with BITS_PER_LONG_LONG too.
BTW,  please take a look at the discussion:

https://patchwork.kernel.org/patch/8824091/

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel