Re: [Xen-devel] [PATCH v3 06/26] ARM: GICv3 ITS: introduce device mapping

[Julien Grall <julien.grall@xxxxxxx>]

On 01/04/17 09:01, Vijay Kilari wrote:
> Hi Andre,
Hi Vijay,

> On Fri, Mar 31, 2017 at 11:35 PM, Andre Przywara <andre.przywara@xxxxxxx> wrote:
> > +    /* An Interrupt Translation Table needs to be 256-byte aligned. */
> > +    itt_addr = _xzalloc(nr_events * hw_its->itte_size, 256);
>       As I mentioned, in previous version, if itt_addr is not enough size,
> ITS would overwrite and corrupt memory.
> Similar to size passed in MAPD cmd, itt_addr should also be allocated of size
> ROUNDUP(nr_events, LPI_BLOCK).
ROUNDUP(nr_events, LPI_BLOCK) would still be wrong as the MAPD command 
works in term of bits. You have to round up to the next bit.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel