Re: [Xen-devel] Xen Security Advisory 206 - xenstore denial of service via repeated update

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Ian Jackson writes ("Re: [Xen-devel] Xen Security Advisory 206 - xenstore 
denial of service via repeated update"):
> > [-Werror=bool-operation]
> >     if (!domain->wrl_delay_logged++) {
> 
> I think this warning is wrong.
...
> It's a shame that we can't disable the warning about incrementing or
> decrementing booleans, from other possible useful warnings such as
> attempts to bitwise-invert them.

Michael, can you confirm whether the patch below fixes it for you ?

If so we will commit it to staging, and also add this to the XSA-206
series (which we are currently waiting to apply to the stable trees...)

Thanks,
Ian.

diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index 773d646..3b0ff16 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -5,6 +5,7 @@ MAJOR = 3.0
 MINOR = 3
 
 CFLAGS += -Werror
+CFLAGS += -Wno-bool-operation
 CFLAGS += -I.
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel