[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6] altp2m: Introduce external-only and limited use-cases


  • To: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Date: Tue, 4 Apr 2017 14:21:48 -0400
  • Cc: Sergej Proskurin <proskurin@xxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 04 Apr 2017 18:22:06 +0000
  • Ironport-phdr: 9a23:/OLpfRFOh1UUvCz/yW4oJp1GYnF86YWxBRYc798ds5kLTJ76psW9bnLW6fgltlLVR4KTs6sC0LuI9fi4EjVYut6oizMrSNR0TRgLiMEbzUQLIfWuLgnFFsPsdDEwB89YVVVorDmROElRH9viNRWJ+iXhpTEdFQ/iOgVrO+/7BpDdj9it1+C15pbffxhEiCCzbL52LRi6txndutUZjYd/Nqo8xAbCr2dVdehR2W5mP0+YkQzm5se38p5j8iBQtOwk+sVdT6j0fLk2QKJBAjg+PG87+MPktR/YTQuS/XQcSXkZkgBJAwfe8h73WIr6vzbguep83CmaOtD2TawxVD+/4apnVAPkhSEaPDMi7mrZltJ/g75aoBK5phxw3YjUYJ2ONPFjeq/RZM4WSXZdUspUUSFODJm8b48SBOQfO+hWoZT2q18XoRegGQWgAeXiwSJKiHDrx603y/kvHx/I3AIgGNIAs3rao9v6O6gQTe+7w7LFzSnBYv5MxTvx9IbFfxAnrPqRXbxwa83RyUw3Gg3LlFqQr43lMC2R1u8QvWaU8fdrW+O1i2E9sQ5xrCWky8AxhYnGm40a1F/E9T9jz4suOd25SFJ0Yd6jEJdKsSGaLJF5TtktQ2FvpiY307sLsoO4cigS0Jkr2hHSZvOdf4WI/x7vTvidLDhmiH5/Zb6ygQu5/1K6xe3mTMa01U5Hri9CktbRqH8AzwfT6s2bSvtl+UehxCqP2xjT6u5aJUA0krLWK4I7zb4ql5oTrF/DEjXqmET2kKCWdkIk9vKu6+v7ebXpuoWQN4p1igH6Kqgum8q/DvokMgUWQmSW9uux2Kfj8EHkWrlGkPI7nrfDvJzHPcgbo7S2Aw5R0oYt8Ra/CDKm3cwFknkIMV1KZh2Hj5LzNFzVPPD5Deuwg1SrkDtxwfDGJafuDo/CLnjEjrftZax95FJEyAov0dBf4IpZCq0bL/L2QEDxr8bUDhsnPAyyzObmCMty1ocFVGOOHKCZNr/SsV6G5uIuP+aAfpMauDH4K/I9/f7hkWc5mUMBfamuxZYWZ263HvJ/L0qEf3XsnMkOEWMRswo6Tezqk0GCUSVJa3e9Qa084Ck7CJihDYfBWI+inKCB0D28Hp1MaWBMEkqMHmvwd4WYR/cMbzqfItd7kjwDTrihSJIh1QuvtA/80LdnNfTb9TECuZLi0th5/fHTlQw39TBuEsuSzXmHT3tokWMQWz82wKd/rFR8yliZ16h0mf5YGsZP6PNKSQc6MpjcwvdkBNDvQA7OYtaJSEq8QtWnDjA9VM4+w9gLY0xlAdWtkgjD3za2A78Sj7GEHpo0/b/G33fvKcdx0WrJ1K4mj1k+XMRPL2Ori7Vj+AjSG47JiUSZlqmweasA2y7N8X+JzXCSs0FATA5wTaLFUGgdZkTNs9v5+0fCT76yBrQnKQZB0tOCKrBUZdHzkVpGQ/Lja5ziZDeNkmK5Hl6rjpeBaoX7dmFViDnUDUEf1QQe+3mXOAwWFCqnv2PQDTcoHlXqNQek4eR47X+2UEIw5wWLdFF6kaq4/AYPgv6RQO9V2agL6wk7rDAhMF+73t/SQ/aN7yV7daxSKYcx71tK2njQnxBsNZynaaZ5jxgRdBoh7BCm7Al+FogVyZtil3gt1gcnbPvCiF4=
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 04/04/2017 11:24 AM, Tamas K Lengyel wrote:
Currently setting altp2mhvm=1 in the domain configuration allows access to the
altp2m interface for both in-guest and external privileged tools. This poses
a problem for use-cases where only external access should be allowed, requiring
the user to compile Xen with XSM enabled to be able to appropriately restrict
access.

In this patch we deprecate the altp2mhvm domain configuration option and
introduce the altp2m option, which allows specifying if by default the altp2m
interface should be external-only or limited. The information is stored in
HVM_PARAM_ALTP2M which we now define with specific XEN_ALTP2M_* modes.
If external mode is selected, the XSM check is shifted to use XSM_DM_PRIV
type check, thus restricting access to the interface by the guest itself. Note
that we keep the default XSM policy untouched. Users of XSM who wish to enforce
external mode for altp2m can do so by adjusting their XSM policy directly,
as this domain config option does not override an active XSM policy.

Also, as part of this patch we adjust the hvmop handler to require
HVM_PARAM_ALTP2M to be of a type other then disabled for all ops. This has been
previously only required for get/set altp2m domain state, all other options
were gated on altp2m_enabled. Since altp2m_enabled only gets set during set
altp2m domain state, this change introduces no new requirements to the other
ops but makes it more clear that it is required for all ops.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
Signed-off-by: Sergej Proskurin <proskurin@xxxxxxxxxxxxx>
Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.