Re: [Xen-devel] [PATCH v2 3/5] tmem: By default to join an shared pool it must be authorized.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.04.17 at 21:10, <konrad.wilk@xxxxxxxxxx> wrote:
> @@ -1530,7 +1529,8 @@ int do_tmem_new_pool(domid_t this_cli_id,
>              pool->shared = 0;
>              goto out;
>          }
> -        if ( client->shared_auth_required && !tmem_global.shared_auth )
> +        /* By default only join domains that are authorized by admin. */
> +        if ( !tmem_global.shared_auth )

Why "by default"? Is this comment really useful here? Other than
that the patch looks okay, but I won't claim to understand enough
of tmem to know this is sufficiently backwards compatible, so I
won't claim to have reviewed it in full.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel