Re: [Xen-devel] [PATCH 3/3] tools: sched: add support for 'null' scheduler

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Apr 07, 2017 at 12:05:01PM +0200, Dario Faggioli wrote:
> On Fri, 2017-04-07 at 10:42 +0100, Wei Liu wrote:
> > On Thu, Apr 06, 2017 at 05:18:33PM +0200, Dario Faggioli wrote:
> > > 
> > > Wei acked this patch in v1 (20170321170902.ndk6h5ylyfkk4coo@citrix.
> > > com)
> > > but that was before you raised this, so I'm happy to resend with
> > > this
> > > changed, and doing whatever he prefers with his ack.
> > > 
> > > Wei?
> > 
> > I don't feel strongly about this. But if you want to return success
> > in
> > the get function, please make sure you initialise output to a known
> > state, instead of returning random garbage.
> > 
> Sure. That should not be a problem, as libxl_domain_sched_params_get()
> calls, as the first thing it does, libxl_domain_sched_params_init(),
> which sets all scinfo fields to their default.
> 
> Whatever I return, I won't touch scinfo at all, which means I'm just
> returning those defaults.
> 

That sounds fine.

> So, can the below patch --which would make George much happier :-D
> --also have your Ack?
> 

Yes.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel