[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/4] xen/mce: make 'severity_cpu' private to its users



>>> On 07.04.17 at 15:48, <JBeulich@xxxxxxxx> wrote:
>>>> On 06.04.17 at 14:33, <haozhong.zhang@xxxxxxxxx> wrote:
>> The current 'severity_cpu' is used by both mcheck_cmn_handler() and
>> mce_softirq(). If MC# happens during mce_softirq(), the values set in
>> mcheck_cmn_handler() and mce_softirq() may interfere with each
>> other. Use private 'severity_cpu' for each function to fix this issue.
>> 
>> Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Other than patch 1 I think this qualifies for 4.9.

And for that reason it is generally better to put bug fixes first in
your series, and pure cleanup last. This patch will now need
re-basing and the committed patch 2 (which I did adjust as
necessary to apply on its own).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.