Re: [Xen-devel] [PATCH for-4.9] x86/emul: Drop more redundant ctxt.event_pending checks

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/04/17 13:24, Paul Durrant wrote:
>> -----Original Message-----
>> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
>> Sent: 10 April 2017 13:15
>> To: Xen-devel <xen-devel@xxxxxxxxxxxxx>
>> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Jan Beulich
>> <JBeulich@xxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>; Paul Durrant
>> <Paul.Durrant@xxxxxxxxxx>; Jun Nakajima <jun.nakajima@xxxxxxxxx>; Kevin
>> Tian <kevin.tian@xxxxxxxxx>; Julien Grall <julien.grall@xxxxxxx>
>> Subject: [PATCH for-4.9] x86/emul: Drop more redundant
>> ctxt.event_pending checks
>>
>> Since c/s 92cf67888a, x86_emulate_wrapper() asserts stricter behaviour
>> about
>> the relationship between X86EMUL_EXCEPTION and ctxt.event_pending.
>>
>> These removals should have been included in the aforementioned
>> changeset, and
>> were only omitted due an oversight.
>>
> As long as suitable assertions are in place...
>
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

The assertion in question is

ASSERT(ctxt->event_pending == (rc == X86EMUL_EXCEPTION));

in x86_emulate_wrapper() which transparently replaces x86_emulate() in
debug builds.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel