Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote:
> On 10/04/17 14:27, Wei Liu wrote:
> > No functional change.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Throughout this series, please make sure you add in proper NULL'ing of
> freed data.
> 
> While this patch is no functional change at the moment, you have
> introduced a latent double-free bug for if (/when) pv_domain_destroy()
> gets used on a failed create path.
> 

No it won't. I made pv_domain_initialise idempotent.

> Please make all of these functions idempotent when breaking them out.
> 

This is a good point. I can make this one idempotent as well.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel