Re: [Xen-devel] [PATCH v2 5/9] mm: Do not discard already-scrubbed pages softirqs are pending

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 04/13/2017 11:41 AM, Jan Beulich wrote:
>>>> On 03.04.17 at 18:50, <boris.ostrovsky@xxxxxxxxxx> wrote:
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> To be honest, without a proper description and with an apparently
> not really well formed title I don't want to start guessing what the
> patch intends, and whether the changes done match that intention.
> I guess this should really have been an RFC ...

There was an RFC for this
(https://lists.xenproject.org/archives/html/xen-devel/2017-02/msg03237.html)
but your point is well taken.

Commit message should have been something like:

    To avoid delaying softirq processing while scrubbing check
    for softirqs every 256 pages. If softirq is pending, stop scrubbing
    and merge the partially-scrubbed buddy by breaking the clean
    portion into smaller power-of-2 chunks. Then repeat the same
    process for the dirty part.

I was about to post the new version of this series, with dirty bit per
page. I'll make updates based on your comments today (and yesterday) and
if you review this patch in this version I'll include your comment into
that version as well.


-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel