Re: [Xen-devel] [PATCH v2 for-next v2 6/8] x86/mm: move two PV hypercalls from x86_64/mm.c to pv/mm.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.04.17 at 12:37, <wei.liu2@xxxxxxxxxx> wrote:
> On Wed, Apr 19, 2017 at 09:33:28AM -0600, Jan Beulich wrote:
>> >>> On 03.04.17 at 13:22, <wei.liu2@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/pv/mm.c
>> > +++ b/xen/arch/x86/pv/mm.c
>> > @@ -4106,6 +4106,74 @@ int mmio_ro_do_page_fault(struct vcpu *v, unsigned 
>> > long addr,
>> 
>> Considering this file is still 4k lines, I'd prefer if stuff not obviously
>> belonging here could be placed elsewhere.
> 
> Looking back to previous patch's commit message, I can split this file
> into more files: two or three for emulation code, one for grant table
> code, one or two for hypercalls.
> 
> Would that be ok for you?

Oh, yes, certainly, provided you don't need to make overly many
static functions non-static.

> If yes, do you have preferences for file names?

Well, no, not really (short of saying "use sensible ones"). If there are
counterparts elsewhere in the tree, naming them the same would of
course be nice (like grant_table.c, despite me disliking the underscore).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel