Re: [Xen-devel] [PATCH v8 for-4.9 1/5] hvm/dmop: Box dmop_args rather than passing multiple parameters around

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/04/17 15:17, Julien Grall wrote:
> Hi Jennifer,
>
> I don't see any cover letter for this series, so I will answer here.
>
> Looking at the code, it looks like a new feature rather than a bug
> fix. Am I right?
>
> Could you explain what would be the benefits and risks to get this
> code in the release?
>
> I also like to hear the opinion of the x86 maintainers about getting
> this code in Xen 4.9.

Patch 1 is a bug in the existing implementation, which absolutely needs
fixing.

Patch 4 it is a correction to the DM OP ABI (which is still modifiable,
before becoming properly stable when 4.9 releases).  If that were
pospond to 4.10, We'd have to burn the existing modified_memory subop
and introduce a new corrected one.

The intermediate patches are fallout from previous rounds of review.


One item on my TODO list is to re-review all dmops for proper
continuability before 4.9 release, so I make no promises that there wont
be further bugfixes needing to get into 4.9.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel