Re: [Xen-devel] [PATCH 2/2][XTF] xtf/vpmu: MSR read/write tests for VPMU

[Mohit Gambhir <mohit.gambhir@xxxxxxxxxx>]

On 04/21/2017 05:43 AM, Wei Liu wrote:
> On Thu, Apr 20, 2017 at 04:40:08PM -0400, Mohit Gambhir wrote:
> > This patch tests VPMU functionality in the hypervisor on Intel machines.
> > The tests write to all valid bits in the MSRs that get exposed to the guests
> > when VPMU is enabled. The tests also write invalid values to the bits
> > that should be masked and expect the wrmsr call to fault.
> >
> > The tests are currently unsupported for AMD machines and PV guests.
> >
> > Signed-off-by: Mohit Gambhir <mohit.gambhir@xxxxxxxxxx>
> [...]
> > +void test_main(void)
> > +{
> > +    /* Architectural Performance Monitoring Version */
> > +    uint8_t ver;
> > +
> > +    /* Number of general purpose counter registers */
> > +    uint8_t ngregs;
> > +
> > +    /* Number of fixed function counter registers */
> > +    uint8_t nfregs;
> > +
> > +    /* Bit width of general-purpose, performance monitoring counter */
> > +    uint8_t ngbits;
> > +
> > +    if ( IS_DEFINED(CONFIG_PV) )
> > +    {
> > +        printk("VPMU testing for PV guests currently unsupported\n");
> > +        goto out;
> > +    }
> > +
> > +    if ( vendor_is_amd )
> > +    {
> > +        printk("VPMU testing for AMD currently unsupported\n");
> > +        goto out;
> > +    }
> These two cases should probably return SKIP instead of SUCCESS.
Fixed in v2
> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel