Re: [Xen-devel] Coding style

[Julien Grall <julien.grall@xxxxxxxxx>]

Hello,

On Thu, 27 Apr 2017, 20:12 Goel, Sameer, <sgoel@xxxxxxxxxxxxxx> wrote:

I am trying to port a Linux driver to Xen. After making the changes it seems that there are enough changes to say that this driver is different enough as compared to the original file. But it still has code from the original author that is used as is.

Based on the CODING_STYLE document I was following the Linux coding style for this file. Since, the file looks a lot different, I am wondering if I should convert this to Xen coding style?

My concern is if we diverge too much from Linux we will increase the maintainance cost.

It will be very difficult to backport patch and we would not benefit from Linux testing.

I did this mistake with SMMU v2 and I had to rewrite everything 6 months later.

So before giving any answer here, I'd like to understand what changes you had to make.

Cheers, 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel