Re: [Xen-devel] [PATCH] kexec: Provide user friendly option for memory limit

[Simon Crowe <simon.crowe@xxxxxxxxxx>]

Jan

Ok i will make the change and resubmit

Thanks again

Regards

On Fri, Apr 28, 2017 at 11:37 AM +0100, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>> On 27.04.17 at 14:22,  wrote:
> @@ -162,6 +166,10 @@ static void __init parse_crashkernel(const char *str)
>              kexec_crash_area.start = parse_size_and_unit(cur = str + 1, &str);
>          else if ( *str == '<' )
>              kexec_crash_area_limit = parse_size_and_unit(cur = str + 1, &str);
> +        else if ( !strncmp(str, ",below=", 7) )
> +        {
> +            kexec_crash_area_limit = parse_size_and_unit(cur = str + 7, &str);
> +        }
>          else
>              printk(XENLOG_WARNING "crashkernel: '%s' ignored\n", str);

The braces you add are inconsistent with surrounding code. With
them dropped
Reviewed-by: Jan Beulich 

You should also have Cc-ed the maintainer of the code.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel