Re: [Xen-devel] [PATCH 03/12 v3] xen/arm: vpl011: Add pl011 uart emulation in Xen

[Julien Grall <julien.grall@xxxxxxx>]

On 01/06/17 11:33, Bhupinder Thakur wrote:
> Hi Julien,
Hi Bhupinder,

> On 22 May 2017 at 19:54, Julien Grall <julien.grall@xxxxxxx> wrote:
> > > +static const struct mmio_handler_ops vpl011_mmio_handler = {
> > > +    .read = vpl011_mmio_read,
> > > +    .write = vpl011_mmio_write,
> > > +};
> > > +
> > > +int vpl011_map_guest_page(struct domain *d, xen_pfn_t gfn)
> >
> > This function should either have the prototype defined in an header if used
> > outside or static.
> >
> > Also, I have asked to use gfn_t and not xen_pfn_t. The former is a typesafe
> > avoiding mix between MFN and GFN.
> The gfn is passed on from the domctl API to this function. Is the
> gfn_t definition exposed to domctl interface? Currently, gfn_t is
> defined in xen/include/xen/mm.h. So I would have to include this
> header file in xen/include/public/domctl.h where I have defined the
> vuart_ops structure containing gfn. Is it ok to include a xen header
> file in the public header file?
No. The only thing I asked is to replace xen_pfn_t by gfn_t in the 
parameter and the caller should use _gfn(...) to do the conversion.
Have a look on how we do in populate_physmap (xen/common/memory.c).

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel