Re: [Xen-devel] [PATCH v11 14/23] x86: refactor psr: CDP: implement get hw info flow.

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-05-31 03:40:40, Jan Beulich wrote:
> >>> On 03.05.17 at 10:44, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/psr.c
> > +++ b/xen/arch/x86/psr.c
> > @@ -207,7 +207,9 @@ static void free_socket_resources(unsigned int socket)
> >      memset(info->dom_ids, 0, ((DOMID_IDLE + 1) + 7) / 8);
> >  }
> >  
> > -static enum psr_feat_type psr_cbm_type_to_feat_type(enum cbm_type type)
> > +static enum psr_feat_type psr_cbm_type_to_feat_type(
> > +                                    const struct psr_socket_info *info,
> > +                                    enum cbm_type type)
> 
> Couldn't you avoid adding this new parameter by checking ...
> 
> > @@ -215,7 +217,18 @@ static enum psr_feat_type 
> > psr_cbm_type_to_feat_type(enum cbm_type type)
> >      {
> >      case PSR_CBM_TYPE_L3:
> >          feat_type = PSR_SOCKET_L3_CAT;
> > +
> > +        /* If type is L3 CAT but we cannot find it in feature array, try 
> > CDP. */
> > +        if ( !info->features[feat_type] )
> 
> ... the props array entry here?
> 
Sure, thanks!

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel