Re: [Xen-devel] [PATCH] x86/mm: drop further relics of translated PV domains

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/06/17 16:30, Jan Beulich wrote:
> For PV domains paging_mode_{refcounts,translate}() are always false as
> of commits 4045953527 ("x86/paging: Enforce PG_external == PG_translate
> == PG_refcounts") and 92942fd3d4 ("x86/mm: drop
> guest_{map,get_eff}_l1e() hooks").
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

There are more cases as well.  I will rebase my series over this patch
when you commit it, because the extra cases only become obvious after
the other cleanup which is still pending.  One style query though...

> @@ -3384,11 +3368,9 @@ long do_mmuext_op(
>  
>              if ( op.arg1.mfn != 0 )
>              {
> -                if ( paging_mode_refcounts(d) )
> -                    rc = get_page_from_pagenr(op.arg1.mfn, d) ? 0 : -EINVAL;
> -                else
> -                    rc = get_page_and_type_from_pagenr(
> -                        op.arg1.mfn, PGT_root_page_table, d, 0, 1);
> +                rc = get_page_and_type_from_pagenr(op.arg1.mfn,
> +                                                   PGT_root_page_table,
> +                                                   d, 0, 1);

Why do you choose to squash the parameters on the right hand side?  For
cases like this, the style of the old code is neater IMO.

~Andrew

>  
>                  if ( unlikely(rc) )
>                  {
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel