[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Is: Release-ack for 4.9, Is:Re: [PATCH for v4.9] livepatch: Wrong usage of spinlock on debug console.



Hi Konrad,

On 11/06/17 13:15, Konrad Rzeszutek Wilk wrote:
On Fri, Jun 09, 2017 at 01:12:10PM -0400, Boris Ostrovsky wrote:
On 06/09/2017 10:16 AM, Konrad Rzeszutek Wilk wrote:
If we have a large amount of livepatches and want to print them
on the console using 'xl debug-keys x' we eventually hit
the preemption check:

  if ( i && !(i % 64) )
  {
        spin_unlock(&payload_lock);
        process_pending_softirqs();
        if ( spin_trylock(&payload_lock) )
                return

<facepalm> The effect is that we have just effectively
taken the lock and returned without unlocking!

CC: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
CC: Jan Beulich <jbeulich@xxxxxxxx>
CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Julien Grall <julien.grall@xxxxxxx>

Julien, could you Release-Ack it for 4.9 please?

Sure:

Release-acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.