Re: [Xen-devel] [PATCH] domctl: improve device assignment structure layout and use

[Julien Grall <julien.grall@xxxxxxx>]

On 09/06/17 14:47, Jan Beulich wrote:
> Avoid needless gaps. Make flags field mandatory for all three
> operations (and rename it to fit the intended future purpose of
> possibly holding more than just one flag).
>
> Also correct a typo in a related domctl.h comment.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> The domain ID treatment of test_assign_device is at least strange:
> Callers pass in a value, but do_domctl() as well as the actual handler
> code ignore them. I think we should increase flexibility here by making
> e.g. DOMID_INVALID a wild card to obtain current behavior, while
> allowing individual domain IDs to be passed in to inquire whether the
> device is assigned to that specific domain.
I forgot to answer on this bit. I agree that the current behavior is 
strange. I would be in favor of your suggestion.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel