Re: [Xen-devel] [Resend][PATCH 04/17] rbtree: empty nodes have no color

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.06.17 at 18:42, <dario.faggioli@xxxxxxxxxx> wrote:
> On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote:
>> Empty nodes have no color.  We can make use of this property to
>> simplify the
>> code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros.
>> 
> Mmm... you have significantly cut the changelog. I appreciate that some
> of the removed text speaks about a function being removed, which we
> don't have in our tree. However:
> 
>  - the central part of the changelog, does not speak about 
>    rb_init_node() being removed, and so you can keep it;
> 
>  - leave a mark in the changelog itself (like a one liner, surrounded
>    by '[' ']') about the fact that you alrered the original changelog.

Even better would imo be to keep the description as is and
add, between the original S-o-b-s (and other tags) and yours,
the changes done to the original commit to fit our tree and
purposes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel