Re: [Xen-devel] [PATCH 06/14 v4] xen/arm: vpl011: Add a new domctl API to initialize vpl011

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

On 14 June 2017 at 13:05, Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx> wrote:
> Hi Stefano,
>
> On 7 June 2017 at 04:56, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>>>  static int set_vnuma_info(libxl__gc *gc, uint32_t domid,
>>> @@ -788,6 +791,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
>>>      if (xc_dom_translated(dom)) {
>>>          state->console_mfn = dom->console_pfn;
>>>          state->store_mfn = dom->xenstore_pfn;
>>> +        state->vuart_gfn = dom->vuart_gfn;
>>>      } else {
>>>          state->console_mfn = xc_dom_p2m(dom, dom->console_pfn);
>>>          state->store_mfn = xc_dom_p2m(dom, dom->xenstore_pfn);
>>
>> vuart_gfn was introduced in patch #4, why are we setting it only now?
>
> I think this change can be moved to patch #5, which initializes
> dom->vuart_gfn, which is required for this change.

I will move this change to patch #4 only and move patch #4 after patch #5.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel