Re: [Xen-devel] [RFC PATCH v3 04/10] arm/mem_access: Add short-descriptor pte typedefs

[Julien Grall <julien.grall@xxxxxxx>]

Hi Sergej,

On 06/15/2017 12:05 PM, Sergej Proskurin wrote:
> The current implementation does not provide appropriate types for
> short-descriptor translation table entries. As such, this commit adds new
> types, which simplify managing the respective translation table entries.
>
> Signed-off-by: Sergej Proskurin <proskurin@xxxxxxxxxxxxx>
> ---
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
> ---
> v3: Add more short-descriptor related pte typedefs that will be used by
>      the following commits.
> ---
>   xen/include/asm-arm/page.h | 104 +++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 104 insertions(+)
page.h is already big and I don't like the idea of mixing lpae and short 
descriptor in the same header. Hence the latter is only used for guest 
page table walk.
As mentioned in a follow-up patch, I would like to start moving out LPAE 
code and short descriptor code in separate header.
I am happy if you only move short-descriptor for now.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel