[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 19/24] xen/arm: p2m: Redefine mfn_to_page and page_to_mfn to use typesafe



Hi Stefano,

On 16/06/2017 00:37, Stefano Stabellini wrote:
On Tue, 13 Jun 2017, Julien Grall wrote:
The file xen/arch/arm/p2m.c is using typesafe MFN in most of the place.
This requires caller to mfn_to_page and page_to_mfn to use _mfn/mfn_x.

To avoid extra _mfn/mfn_x, re-define mfn_to_page and page_to_mfn within
xen/arch/arm/p2m.c to handle typesafe MFN.

This is the same thing that x86/p2m.c does. At some point one has to
wonder if it makes sense to just bite the bullet and change mfn_to_page
everywhere.

The point of those re-definition is to split the work in smaller series and between multiple people rather than requiring one to do the full clean-up. It is quite a boring task but not as mechanical as you think because often you would need to rework a bit the code around.

When we end-up to have the source code using typesafe MFN then we can have a patch dropping the definition. Ideally all the mfn_to_* and *_to_mfn should be typesafe. But this is a longer term goal and not my plan here.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.