Re: [Xen-devel] [PATCH] memory: don't suppress P2M update in populate_physmap()

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 06/20/2017 01:40 PM, Andrew Cooper wrote:
> On 20/06/17 13:39, Julien Grall wrote:
> > Hi,
> >
> > On 06/20/2017 09:37 AM, Andrew Cooper wrote:
> > > On 20/06/17 07:19, Jan Beulich wrote:
> > > > Commit d18627583d ("memory: don't hand MFN info to translated guests")
> > > > wrongly added a null-handle check there - just like stated in its
> > > > description for memory_exchange(), the array is also an input for
> > > > populate_physmap() (and hence can't reasonably be null). I have no idea
> > > > how I've managed to overlook this.
> > > >
> > > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Am I correct that this is not a bug and only a pointless check?
> This is a partial reversion of d18627583d and needs to be included in
> 4.9, to avoid a regression.
Would you mind to explain why this would introduce regression? AFAICT 
the check is just redundant, so keeping it is not that bad.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel