Re: [Xen-devel] [PATCH 04/11] domctl: restrict DOMCTL_set_target to HVM domains

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/06/17 10:33, Jan Beulich wrote:
> Both the XSA-217 fix and
> lists.xenproject.org/archives/html/xen-devel/2017-04/msg02945.html
> make this assumption, so let's enforce it.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper@xxxxxxxxxx>, although...

>
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -1071,7 +1071,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe
>              break;
>          }
>  
> -        ret = xsm_set_target(XSM_HOOK, d, e);
> +        ret = -EOPNOTSUPP;
> +        if ( is_hvm_domain(e) )
> +            ret = xsm_set_target(XSM_HOOK, d, e);
>          if ( ret ) {

... do you mind fixing this style while you are here?

~Andrew

>              put_domain(e);
>              break;
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel