Re: [Xen-devel] [PATCH 1/2] x86/mm: Misc nonfunctional cleanup

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.06.17 at 11:31, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -1843,16 +1852,19 @@ void page_unlock(struct page_info *page)
>      } while ( (y = cmpxchg(&page->u.inuse.type_info, x, nx)) != x );
>  }
>  
> -/* How to write an entry to the guest pagetables.
> - * Returns 0 for failure (pointer not valid), 1 for success. */
> -static inline int update_intpte(intpte_t *p, 
> -                                intpte_t old, 
> +/*
> + * How to write an entry to the guest pagetables.
> + * Returns 0 for failure (pointer not valid), 1 for success.
> + */
> +static inline int update_intpte(intpte_t *p,
> +                                intpte_t old,
>                                  intpte_t new,
>                                  unsigned long mfn,
>                                  struct vcpu *v,
>                                  int preserve_ad)
>  {
>      int rv = 1;

Both this variable and the function's return type appear to want
to be bool, too.

> @@ -4083,8 +4105,8 @@ static int destroy_grant_pte_mapping(
>  
>      /* Delete pagetable entry. */
>      if ( unlikely(!UPDATE_ENTRY
> -                  (l1, 
> -                   (l1_pgentry_t *)va, ol1e, l1e_empty(), mfn, 
> +                  (l1,
> +                   (l1_pgentry_t *)va, ol1e, l1e_empty(), mfn,
>                     d->vcpu[0] /* Change if we go to per-vcpu shadows. */,
>                     0)) )

Could I talk you into moving at least the first argument onto the
first line here?

Preferably with these taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel