Re: [Xen-devel] [PATCH v4 17/27] x86/traps: move some PV specific functions and struct to pv/traps.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/06/17 18:11, Wei Liu wrote:
> +void __init pv_trap_init(void)
> +{
> +    /* The 32-on-64 hypercall vector is only accessible from ring 1. */
> +    _set_gate(idt_table + HYPERCALL_VECTOR,
> +              SYS_DESC_trap_gate, 1, entry_int82);
> +
> +    /* Fast trap for int80 (faster than taking the #GP-fixup path). */
> +    _set_gate(idt_table + 0x80, SYS_DESC_trap_gate, 3, &int80_direct_trap);
> +
> +    open_softirq(NMI_MCE_SOFTIRQ, nmi_mce_softirq);
> +}
> +
> +int send_guest_trap(struct domain *d, uint16_t vcpuid, unsigned int trap_nr)

Just like guest_has_trap_callback(), there is only a single caller and
it has a struct vcpu in its hand.

I'd recommend breaking out a cleanup patch which switches this to:

int pv_raise_interrupt(struct vcpu *v, uint8_t vector);

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel