Re: [Xen-devel] [PATCH v5 01/13] x86: move callback_op code to pv/callback.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/06/17 09:48, Wei Liu wrote:
> On Tue, Jun 27, 2017 at 12:13:19AM -0600, Jan Beulich wrote:
>>>>> Wei Liu <wei.liu2@xxxxxxxxxx> 06/26/17 6:29 PM >>>
>>> --- a/xen/arch/x86/pv/Makefile
>>> +++ b/xen/arch/x86/pv/Makefile
>>> @@ -1,6 +1,7 @@
>>  >obj-y += hypercall.o
>>  >obj-y += traps.o
>>  >
>>> +obj-y += callback.o
>>  >obj-bin-y += dom0_build.init.o
>>  >obj-y += domain.o
>>  >obj-y += emulate.o
>>
>> Not something to be dealt with in this patch, but - is there a reason we
>> have two groups of object files here? I see none, and hence would have
>> expected this to be a single sorted list instead of two.
>>
> No. It just so happened I added a newline at some point.
>
> I will submit a patch to fix this at some point.

I'd suggest splitting the obj-y and obj-bin-y lists, as it will make the
Makefile easier to read.  That appears to have been the original
intention behind the space in the first place.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel